Skip to content

Add area tag to default valid_tags in IFilterSchema#127

Open
wesleybl wants to merge 1 commit into
mainfrom
tag-area
Open

Add area tag to default valid_tags in IFilterSchema#127
wesleybl wants to merge 1 commit into
mainfrom
tag-area

Conversation

@wesleybl

@wesleybl wesleybl commented Jul 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

The HTML sanitizer allows <map> by default but strips its required child element <area>, making image maps unusable. Add <area> to the default valid_tags list so image maps work out of the box.

Closes plone/Products.CMFPlone#4348

@mister-roboto

mister-roboto commented Jul 2, 2026

Copy link
Copy Markdown

@wesleybl thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@wesleybl

wesleybl commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@wesleybl

wesleybl commented Jul 2, 2026

Copy link
Copy Markdown
Member Author

Should I create an upgrade step for this?

@wesleybl

wesleybl commented Jul 3, 2026

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@wesleybl
Add area tag to default valid_tags in IFilterSchema
612588d 
The HTML sanitizer allows <map> by default but strips its required
child element <area>, making image maps unusable. Add <area> to the
default valid_tags list so image maps work out of the box.
@davisagli

davisagli commented Jul 6, 2026

Copy link
Copy Markdown
Member

Should I create an upgrade step for this?

@wesleybl You can if you want. I would make sure that it only allows area if map is still allowed. It's also ok if we skip the upgrade step and it is only allowed for new sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davisagli davisagli davisagli approved these changes
@thet thet Awaiting requested review from thet
@mauritsvanrees mauritsvanrees Awaiting requested review from mauritsvanrees

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HTML sanitizer allows <map> but strips <area>, making image maps unusable

3 participants

@wesleybl @mister-roboto @davisagli